Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend PickerNetwork component functionality #11856

Merged
merged 12 commits into from
Oct 23, 2024
Merged

feat: extend PickerNetwork component functionality #11856

merged 12 commits into from
Oct 23, 2024
+304 −210

Conversation

vinnyhoward
Copy link
Contributor

Description

This PR changes the PickerNetwork to allow the network name to be hidden. These changes are necessary to accommodate the Header Update design requirements coming up. However the aim is to introduce very little change (other than padding) to what is pre-existing but by passing in the prop of hideNetwork it changes into the future design

Related issues

Related: #11763

Manual testing steps

  1. View any instance of PickerNetwork being used. For example the PickerNetwork in header in the home screen

Screenshots/Recordings

before

After hideNetwork=false the default
after (no prop)

After hideNetwork=true
after (prop)

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners October 17, 2024 22:59
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added team-wallet-ux team-ramp issues related to Ramp features team-design-system All issues relating to design system in Mobile Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e2f4191
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b0de6ec-0450-46cb-938f-3adce9f84d48

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 41c95ec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e12abda-644b-4f1a-88e5-23029b383c40

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8b01538
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a70b60d-808f-478a-9c1f-9259e20b1a27

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 71413b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1398411b-1636-4bea-bcd2-d3c7af0ed6e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

brianacnguyen
brianacnguyen reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment

@vinnyhoward vinnyhoward removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 22, 2024
@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6145fb9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17427ba7-3f9f-49ba-8222-614a935ea042

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d96e4ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/25e93a90-befb-4ee5-ad3c-6cd4cc50754c

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 47b93d5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5661c75e-ce85-49a4-bbe7-9394194284d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 3db0815 Oct 23, 2024
43 checks passed
@brianacnguyen brianacnguyen deleted the feat-extend-picker-network-component branch October 23, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@georgeweiler georgeweiler georgeweiler approved these changes

@gambinish gambinish gambinish approved these changes

Assignees
No one assigned
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile team-ramp issues related to Ramp features team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinnyhoward @darkwing @brianacnguyen @georgeweiler @gambinish @metamaskbot