-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend PickerNetwork component functionality #11856
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: e2f4191 Note
|
Bitrise❌❌❌ Commit hash: 41c95ec Note
Tip
|
Bitrise❌❌❌ Commit hash: 8b01538 Note
Tip
|
Bitrise❌❌❌ Commit hash: 71413b0 Note
Tip
|
app/component-library/components/Pickers/PickerNetwork/PickerNetwork.styles.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Pickers/PickerNetwork/PickerNetwork.styles.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small comment
Bitrise✅✅✅ Commit hash: 6145fb9 Note
|
…extend-picker-network-component
…aMask/metamask-mobile into feat-extend-picker-network-component
Bitrise🔄🔄🔄 Commit hash: d96e4ba Note
|
…aMask/metamask-mobile into feat-extend-picker-network-component
Bitrise✅✅✅ Commit hash: 47b93d5 Note
|
Quality Gate passedIssues Measures |
Description
This PR changes the
PickerNetwork
to allow the network name to be hidden. These changes are necessary to accommodate the Header Update design requirements coming up. However the aim is to introduce very little change (other than padding) to what is pre-existing but by passing in the prop ofhideNetwork
it changes into the future designRelated issues
Related: #11763
Manual testing steps
PickerNetwork
being used. For example thePickerNetwork
in header in the home screenScreenshots/Recordings
After
hideNetwork=false
the defaultAfter
hideNetwork=true
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist