-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds GoogleService.plist creation during build process #11863
base: main
Are you sure you want to change the base?
chore: adds GoogleService.plist creation during build process #11863
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 2aa558c Note
Tip
|
…ithub.com:MetaMask/metamask-mobile into NOTIFY-1236/add-GoogleService.plist-build-process
Bitrise❌❌❌ Commit hash: 6208509 Note
Tip
|
Bitrise❌❌❌ Commit hash: 99dc3a2 Note
Tip
|
Bitrise❌❌❌ Commit hash: 8117c03 Note
Tip
|
…ithub.com:MetaMask/metamask-mobile into NOTIFY-1236/add-GoogleService.plist-build-process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the commands listed in the readme and they all worked. Building the app on Android worked as well.
Bitrise❌❌❌ Commit hash: fc72fd8 Note
Tip
|
…ithub.com:MetaMask/metamask-mobile into NOTIFY-1236/add-GoogleService.plist-build-process
Bitrise❌❌❌ Commit hash: 7f67b1e Note
Tip
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR address a need for creating GoogleServices-info.plist file at build process thus avoiding leaving project details exposed. Although this isn't an issue as stated here and here, we're just trying to minimize risk even when they're very low already.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist