Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds GoogleService.plist creation during build process #11863

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

chore: adds GoogleService.plist creation during build process #11863

wants to merge 34 commits into from
+155 −12

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR address a need for creating GoogleServices-info.plist file at build process thus avoiding leaving project details exposed. Although this isn't an issue as stated here and here, we're just trying to minimize risk even when they're very low already.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-10-18 at 11 27 28

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform team-notifications Notifications team labels Oct 18, 2024
@Jonathansoufer Jonathansoufer self-assigned this Oct 18, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners October 18, 2024 10:28
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2aa558c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58e22e5b-0159-44cc-81bb-2880df003499

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6208509
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c96ecb8-0655-481d-94fd-23ec7f9959ab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 19, 2024
@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 99dc3a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7c70915-e5f0-4761-82b4-2de0b5452beb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8117c03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffee09f3-cd27-45c6-aeff-29d2860da624

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

legobeat
legobeat reviewed Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
legobeat
legobeat reviewed Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
legobeat
legobeat reviewed Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
legobeat
legobeat reviewed Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@legobeat legobeat changed the title feat: adds GoogleService.plist creation during build process chore: adds GoogleService.plist creation during build process Oct 23, 2024
legobeat
legobeat reviewed Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Jonathansoufer
update README
56dc31e
@Jonathansoufer
Merge branch 'NOTIFY-1236/add-GoogleService.plist-build-process' of g…
2e9b675 
…ithub.com:MetaMask/metamask-mobile into NOTIFY-1236/add-GoogleService.plist-build-process
owencraston
owencraston previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the commands listed in the readme and they all worked. Building the app on Android worked as well.

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fc72fd8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ecc7cf6-a169-47af-a8ff-10ae2d87bc0b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Jonathansoufer
remove pre build stage
cd6f12b
@Jonathansoufer
Merge branch 'NOTIFY-1236/add-GoogleService.plist-build-process' of g…
7f67b1e 
…ithub.com:MetaMask/metamask-mobile into NOTIFY-1236/add-GoogleService.plist-build-process
@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7f67b1e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d6b8153-3499-46e7-8a49-7fc640227443

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

legobeat
legobeat requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be causing build failure in Bitrise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legobeat legobeat legobeat requested changes

@owencraston owencraston owencraston left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@Jonathansoufer Jonathansoufer

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team
Projects
PR review queue
Status: Needs more work from the author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jonathansoufer @owencraston @legobeat @cortisiko