feat: add new default networks

[salimtb]

Description

This PR ensures that a predefined list of popular networks (Arbitrum, BSC, Base, Optimism, and Polygon) is automatically added for new users only during the app startup process. The networks are added using NetworkController.addNetwork within the useEffect hook inside the app's initialization flow.

Related issues

Fixes:

Manual testing steps

1. Do a new fresh install app
2. Import/create your wallet
3. check the list of added networks

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d124a74
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/568ed606-1ae5-4bca-8752-d50787757d8b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[salimtb]

no regression tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6fe821fe-745a-460c-9409-49b6d8cec2ca

[gambinish]

Same question about Promise.all here, but code lgtm. Also pulled down and behavior is as expected ✅

[salimtb]

Same question about Promise.all here, but code lgtm. Also pulled down and behavior is as expected ✅

hey @gambinish , regarding the use of promise all, it's possible on extension since he networkSorting is managed by sortedNetworks , but for mobile , we don't have this and we want to add the networks on a certain order.
so i'm going to do it just for extension

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[tommasini]

I wonder if networksToAdd is more accurate, because the networks are not really selected, wdyt?

Suggested change

	const selectedNetworks = PopularList.filter((network) =>
	chainIdsToAdd.includes(network.chainId),
	);
	const { NetworkController } = Engine.context;
	// Loop through each selected network and call NetworkController.addNetwork
	for (const network of selectedNetworks) {
	try {
	await NetworkController.addNetwork({
	chainId: network.chainId,
	blockExplorerUrls: [network.rpcPrefs.blockExplorerUrl],
	defaultRpcEndpointIndex: 0,
	defaultBlockExplorerUrlIndex: 0,
	name: network.nickname,
	nativeCurrency: network.ticker,
	rpcEndpoints: [
	{
	url: network.rpcUrl,
	name: network.nickname,
	type: RpcEndpointType.Custom,
	},
	],
	});
	} catch (error) {
	Logger.error(error);
	}
	}
	}
	const networksToAdd = PopularList.filter((network) =>
	chainIdsToAdd.includes(network.chainId),
	);
	const { NetworkController } = Engine.context;
	// Loop through each selected network and call NetworkController.addNetwork
	for (const network of networksToAdd) {
	try {
	await NetworkController.addNetwork({
	chainId: network.chainId,
	blockExplorerUrls: [network.rpcPrefs.blockExplorerUrl],
	defaultRpcEndpointIndex: 0,
	defaultBlockExplorerUrlIndex: 0,
	name: network.nickname,
	nativeCurrency: network.ticker,
	rpcEndpoints: [
	{
	url: network.rpcUrl,
	name: network.nickname,
	type: RpcEndpointType.Custom,
	},
	],
	});
	} catch (error) {
	Logger.error(error);
	}
	}
	}

[tommasini]

It looks good to me!

I wonder if there is a plan to deprecate this code and add this to all the users?