Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fiat value displayed only for the native token in simulations #11947

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Oct 22, 2024

Description

In the recent changes token exchange rates are determined from marketData which has no value property anymore.
Hence fetchTokenContractExchangeRates was failing because rather than value it should now read price

Please note that this is already fixed in main in the assets-controllers@33.

Related issues

Fixes: #11901

Manual testing steps

  1. Simulations should show fiat values properly

Screenshots/Recordings

Before

After

Screenshot 2024-10-22 at 12 57 38

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner October 22, 2024 10:57
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 22, 2024
@sahar-fehri
Copy link
Contributor

Thank you for this fix 🙏 This patch wont be needed in v33 of assets-controllers 🙏

@sleepytanya
Copy link
Contributor

sleepytanya commented Oct 22, 2024

Bitrise build: https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/bd85cf556ea384d1

Fiat values displayed for all tokens on all Popular networks.

iOS:

ios

Android:

android

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Oct 22, 2024
Copy link

sonarcloud bot commented Oct 24, 2024

@NicolasMassart NicolasMassart merged commit 4b10bfc into release/7.34.0 Oct 24, 2024
35 checks passed
@NicolasMassart NicolasMassart deleted the 11901-bug-fiat-value-displayed-only-for-the-native-token branch October 24, 2024 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants