chore: merge main in 7.33.0 #11957
Merged
chore: merge main in 7.33.0 #11957
+9,059
−4,165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR introduces the Chain Permissions feature, allowing users to grant dapps explicit permissions to switch to specific networks. When the `MM_CHAIN_PERMISSIONS` feature flag is enabled, dapps requesting network changes via `wallet_addEthereumChain` or `wallet_switchEthereumChain` will prompt the user to add permission to access the specified chain IDs and, if granted, subsequent `wallet_switchEthereumChain` requests made to that chainId will not require user confirmation. - Added a new permission `endowment:permitted-chains` with the caveat `restrictNetworkSwitching`. - Updated `wallet_addEthereumChain` and `wallet_switchEthereumChain` methods to integrate with the new chain permissions. - Introduced environment variables `MM_CHAIN_PERMISSIONS` to toggle the feature. - Changed `MULTICHAIN_V1` env variable to `MM_PER_DAPP_SELECTED_NETWORK` (more specific/accurate name) - Implemented validation functions for chain IDs and network parameters. ## **Related issues** Fixes: MetaMask/MetaMask-planning#2883 ## **Manual testing steps** 1. Enable the Chain Permissions feature by setting `MM_CHAIN_PERMISSIONS` **and the new UI** by setting `MM_MULTICHAIN_V1_ENABLED` with the watch script: `MM_CHAIN_PERMISSIONS=1 MM_MULTICHAIN_V1_ENABLED=1 yarn watch:clean` 3. Navigate to a dapp and request a network switch to a chain ID not yet permitted. 4. Observe that a permission prompt appears asking to grant access to the requested network. 5. Approve the permission and verify that the network switch occurs successfully. 6. Repeat the network switch request and confirm that no prompt appears, indicating the permission is saved. 7. Attempt to switch to a different, unpermitted network and deny the permission. Verify that the network does not switch. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ## **Before** ### Switch Flow: https://github.com/user-attachments/assets/cc0ecee6-79c1-40ed-85a7-cb3effed4acb ### Add Flow https://github.com/user-attachments/assets/4d988a80-a020-49b4-89a5-527884a16558 ## **After** ### Connection + Switch Flow The initial connection flow suggests that your granting network permissions too but that is not wired up yet. https://github.com/user-attachments/assets/4a5ba93a-4de4-411e-97c3-abd4794e0539 ### Add Flow https://github.com/user-attachments/assets/41e22694-6aa5-444b-8231-7fccad942465 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR fixed an issue preventing mobile accounts to sync its states (enable/disable) with other clients (platform and extension). [NOTIFY-1218](https://consensyssoftware.atlassian.net/browse/NOTIFY-1218?atlOrigin=eyJpIjoiZTRlYTlkNjVjOGVjNDAyYTljNmM3YTg2NjBiYzllNGYiLCJwIjoiaiJ9) ## **Related issues** Fixes: ## **Manual testing steps** 1. Import the same SRP on Mobile 2. Make sure all accounts are visible on both devices/platforms. If not, import all accounts 3. Switch Notifications state in account "A" on extension. 4. Go to Notifications Settings on mobile and see if the state is propagated. 5. Switch back on mobile 6. Go to extension and see if state is propagated. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/860e2e46-f08a-45fd-b965-a9948ef59630 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [NOTIFY-1218]: https://consensyssoftware.atlassian.net/browse/NOTIFY-1218?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
## **Description** Fixes copy of contract address on token details page ## **Related issues** Fixes: ## **Manual testing steps** 1. Go home page 2. Click on any token 3. click on copy button of the contract address 4. paste the address anywhere 5. You should see complete contract address ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/3169a99c-117c-48de-a5cb-f084e9b25949 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/973a7e85-4894-424d-bd65-7d34787a37f2 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…t open PR (#11842) ## **Description** This PR makes a minor change to make the release action depend on an existing release branch before running the action. The new action will create a PR for the release branch and creating a PR for the changelog and version bump against the release branch. ## **Related issues** Fixes: ## **Manual testing steps** 1. Confirm there is a release branch 2. Run the GH action 3. See successful run and 2 PRs ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** NA ### **After** - Example PR: #11887 - Example Changelog PR: #11888 - Successful Action Run: https://github.com/MetaMask/metamask-mobile/actions/runs/11411806607 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This pull request resolves the secp256k1 to the latest version as a precaution. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me>
## **Description** Added a try catch around the infura calls so Sentry does not pick up an error from axois when the request fails due to poor connection. ## **Related issues** Fixes: [This issue](https://metamask.sentry.io/issues/5665770057/?project=2299799&referrer=github_integration) ## **Manual testing steps** - Open the app, log in, disconnect from the internet. - - App should now handle that failure instead of the api throwing an error which is caught by Sentry. ## **Screenshots/Recordings** ### **Before** <img width="489" alt="Screenshot 2024-10-15 at 14 53 11" src="https://github.com/user-attachments/assets/2e48befa-9e7f-41f2-98e9-e1d3a51cef8d"> ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** A PR that addresses all 50 current linting issues found in the repo when running `yarn lint` ## **Related issues** Fixes: 1. Run `yarn lint` and see there are no linting issues remaining. 2. Run `yarn test:unit` and see all tests pass. ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** <img width="514" alt="Screenshot 2024-09-13 at 14 03 28" src="https://github.com/user-attachments/assets/afb5a55c-94ce-44ad-808f-2f051c559e76"> ### **After** <img width="274" alt="Screenshot 2024-09-13 at 14 01 40" src="https://github.com/user-attachments/assets/58417fc7-5647-4028-9702-d1a79e4f550a"> <img width="365" alt="Screenshot 2024-09-13 at 14 02 28" src="https://github.com/user-attachments/assets/33c894a8-c83d-41bc-90a7-52c512915e4e"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This is the initial test and foundation for Off-Ramp testing. It should go through the onboarding screen, select region, select payment method, and show the screen to build a Sell quote. ## **Related issues** https://consensyssoftware.atlassian.net/browse/RAMPS-1869 ## **Manual testing steps** This test is consistently passing: ``` PASS e2e/specs/ramps/offramp.spec.js (36.081 s) smokeAssets OffRamp ✓ should select Region and Payment Method to see the Build Sell Quote screen (16087 ms) Test Suites: 1 passed, 1 total Tests: 1 passed, 1 total Snapshots: 0 total Time: 36.139 s ``` ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR enables staking on both Ethereum mainnet and Holesky. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Ticket: [STAKE-805: [FE] [Stake flow] Integrate stake sdk method](https://consensyssoftware.atlassian.net/browse/STAKE-805) ## **Manual testing steps** 1. Add `export MM_POOLED_STAKING_UI_ENABLED=true` to your .js.env file. 2. Select Ethereum in the asset list 3. Scroll down a bit and click "Stake More" 4. Enter an amount to stake and click "review" 5. On the review screen, click "Continue" 6. You should see the transaction confirmation screen appear. Click "Confirm". 7. The transaction should be submitted and you should be redirected to the Ethereum asset details page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/f90dfc78-b51a-4a6d-aa93-e48cc4146d30 ### **After** <!-- [screenshots/recordings] --> **Update:** On transaction submission, the user is now redirected to the Transactions View. https://github.com/user-attachments/assets/61752a3b-6a7d-4bec-ae3b-a2060ddc257a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…#11608) ## **Description** Allow local development builds to send Sentry performance transactions ## **Related issues** Fixes: MetaMask/mobile-planning#1919 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR addresses multiple areas to improve the stability and maintainability of the project: 1. Fix Non-Regression Tests 2. Code Cleanup 3. Increased Code Quality <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Run non regression test on this branch ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Curtis <Curtis.David7@gmail.com>
## **Description** Adds Gravity Network logo as custom network https://chainlist.org/chain/1625 ## **Related issues** Fixes: No issue created ## **Manual testing steps** 1. Add Gravity as custom network 2. Custom network should appear as network logo (see screenshots) ## **Screenshots/Recordings** <img width="200" alt="Screenshot 2024-10-15 at 7 45 46 AM" src="https://github.com/user-attachments/assets/1a0c76e3-1ff8-4674-85a6-aea4c4ee273b"> <img width="200" alt="Screenshot 2024-10-15 at 7 46 08 AM" src="https://github.com/user-attachments/assets/5ea13ce3-e2dc-41d2-9246-50846fa122ae"> <img width="200" alt="Screenshot 2024-10-15 at 7 46 27 AM" src="https://github.com/user-attachments/assets/49a20a55-db88-4866-8514-be15be3545d9"> <img width="200" alt="Screenshot 2024-10-15 at 7 46 41 AM" src="https://github.com/user-attachments/assets/564ffb70-8535-4495-875e-b1abd12c64f7"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NicolasMassart
added
Run Smoke E2E
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/stake-sdk@0.2.11, npm/secp256k1@4.0.3 |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release/7.33.0 branch with main as an attempt to move forward to merge it.
Can't be merged automatically from Github as it requires a PR.