Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main in 7.33.0 #11957

Merged
merged 13 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ module.exports = {
rules: {
// under discussion
'no-unused-vars': 'off',
'react/no-unstable-nested-components': [
'warn',
{
allowAsProps: true,
},
],
},
},
{
Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/create-release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,10 @@ jobs:
cache: yarn
- name: Install dependencies
run: yarn --immutable
- name: Set Versions
id: set-versions
shell: bash
run: SEMVER_VERSION=${{ github.event.inputs.semver-version }} VERSION_NUMBER=${{ github.event.inputs.version-number }} yarn set-version
- name: Create Release PR
id: create-release-pr
- name: Create Release & Changelog PR
id: create-release-changelog-pr
shell: bash
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
./scripts/create-release-pr.sh ${{ github.event.inputs.previous-version-tag }} ${{ github.event.inputs.semver-version }}
./scripts/create-release-pr.sh ${{ github.event.inputs.previous-version-tag }} ${{ github.event.inputs.semver-version }} ${{ github.event.inputs.version-number }}
7 changes: 5 additions & 2 deletions .js.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ export MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS="true"
# The endpoint used to submit errors and tracing data to Sentry for dev environment.
# export MM_SENTRY_DSN_DEV=

# Multichain Feature flag
export MULTICHAIN_V1=""
# Per dapp selected network (Amon Hen) feature flag
export MM_PER_DAPP_SELECTED_NETWORK=""

export MM_CHAIN_PERMISSIONS=""

#Multichain feature flag specific to UI changes
export MM_MULTICHAIN_V1_ENABLED=""
4 changes: 3 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@
"cucumberautocomplete.steps": ["wdio/step-definitions/**/*.js"],
"cucumberautocomplete.syncfeatures": "wdio/to/features/*.feature",
"cucumberautocomplete.strictGherkinCompletion": true,
"typescript.tsdk": "node_modules/typescript/lib"
"typescript.tsdk": "node_modules/typescript/lib",
"javascript.preferences.importModuleSpecifier": "relative",
"typescript.preferences.importModuleSpecifier": "relative"
}
2 changes: 1 addition & 1 deletion app/actions/onboarding/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ export function clearOnboardingEvents(): ClearEventsAction {
return {
type: CLEAR_EVENTS,
};
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const ContractBoxBase = ({
theme: { colors },
} = useStyles(styleSheet, {});

const IconView = ({ onPress, name, size, testID }: IconViewProps) => (
const renderIconView = ({ onPress, name, size, testID }: IconViewProps) => (
<Pressable style={styles.icon} onPress={onPress} testID={testID}>
<Icon color={colors.icon.alternative} name={name} size={size} />
</Pressable>
Expand Down Expand Up @@ -78,20 +78,19 @@ const ContractBoxBase = ({
)}
</View>
<View style={styles.iconContainer}>
<IconView
onPress={onCopyAddress}
name={IconName.Copy}
size={IconSize.Lg}
testID={COPY_ICON_TEST_ID}
/>
{hasBlockExplorer && (
<IconView
name={IconName.Export}
onPress={onExportAddress}
size={IconSize.Md}
testID={EXPORT_ICON_TEST_ID}
/>
)}
{renderIconView({
onPress: onCopyAddress,
name: IconName.Copy,
size: IconSize.Lg,
testID: COPY_ICON_TEST_ID,
})}
{hasBlockExplorer &&
renderIconView({
onPress: onExportAddress,
name: IconName.Export,
size: IconSize.Md,
testID: EXPORT_ICON_TEST_ID,
})}
</View>
</View>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,21 @@ exports[`Component ContractBoxBase should render correctly 1`] = `
}
}
>
<IconView
name="Copy"
<Component
onPress={[Function]}
size="24"
style={
{
"paddingHorizontal": 6,
}
}
testID="copy-icon"
/>
>
<Icon
color="#6a737d"
name="Copy"
size="24"
/>
</Component>
</View>
</View>
`;
Loading
Loading