Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2808): edit network permissions #11963

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Oct 22, 2024

Description

add and remove permissions to network

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2808

Manual testing steps

I have added screenshot below to see how it looks.

Set these following variables in js.env, otherwise none of these screens will show.
export MM_NETWORK_UI_REDESIGN_ENABLED="1"
export MM_MULTICHAIN_V1_ENABLED="1"
export MM_CHAIN_PERMISSIONS="1"

  1. Go to the in-app brower on the mobile wallet, connect to a dapp like uniswap
  2. Click on the icon on top right header, a bottom sheet opens, click on the manage permissions button
  3. Edit permissions, and confirm, when going back to the screen, permissions should be kept.

Screenshots/Recordings

Before, user was prompted to give permission After, user gave permission and is not prompted to give it
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18s at 3 56 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Oct 22, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 changed the title feat(2808): edit network happy path feat(2808): edit network permissions Oct 23, 2024
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9087c64
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e004f589-acd6-4ee7-a4c0-8cfd97482e63

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 850e31d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16f1256b-1a03-4fb7-a021-721dfe8350c6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8c6d4be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34239b62-c787-464b-8b68-225edf2a8bb2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 24.77064% with 82 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (5e5190f) to head (97d3f43).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...nnectMultiSelector/NetworkConnectMultiSelector.tsx 0.00% 43 Missing ⚠️
...components/Views/AccountConnect/AccountConnect.tsx 36.66% 15 Missing and 4 partials ⚠️
...ts/Views/AccountPermissions/AccountPermissions.tsx 50.00% 9 Missing and 3 partials ⚠️
...etworkVerificationInfo/NetworkVerificationInfo.tsx 37.50% 3 Missing and 2 partials ⚠️
...nts/UI/NetworkSelectorList/NetworkSelectorList.tsx 0.00% 2 Missing ⚠️
...nents/UI/PermissionsSummary/PermissionsSummary.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11963      +/-   ##
==========================================
+ Coverage   54.65%   55.18%   +0.53%     
==========================================
  Files        1744     1760      +16     
  Lines       39333    39795     +462     
  Branches     4878     4965      +87     
==========================================
+ Hits        21497    21962     +465     
+ Misses      16340    16318      -22     
- Partials     1496     1515      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EtherWizard33 EtherWizard33 added team-wallet-ux Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 97d3f43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3aaa6371-5258-4659-a9cb-fe720d10239a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ce956c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55dd78c4-95c0-425f-9468-5fa4c069cfac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

feat-2808-edit-network-happy-path # Please enter a commit message to explain why this merge is necessary,
Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants