Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix 11836 wrong accounts in 2 ledger devices #11967

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Oct 23, 2024

Description

This PR will fix #11835 issue, the details of this PR change include following:

  1. Fix the useBluetoothDevices.ts infinitely loop to setDevices due to devices properties in outside scope of observable inside next() function (devices always is empty object)
  2. Fix the scan.tsx component which always select the first devices due to above change.

Related issues

Fixes: #11835

Manual testing steps

  1. Install MM
  2. Recover from SRP
  3. Pair Ledger Nano X to MM
  4. Pair Ledger Stax to MM
  5. Select Ledger Nano X and verify account list derived from device
  6. Select Ledger Stax and verify account list derived from device

Expected:- 2 different account lists for each device

Screenshots/Recordings

Before

https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBOFJUQnc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--0c57025402bf0df5c50f0a5247c29ddf56cc7e60/RPReplay_Final1729159957.MP4

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 92a3852
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7d48030c-bdba-4934-86bd-debd76b5f1f4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 164aa26
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab59b73b-5ca5-4815-888a-7ea2ffd6064f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4a15c38
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3646c8a2-046e-4141-be9d-369b2499b4e1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 marked this pull request as ready for review October 24, 2024 12:48
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner October 24, 2024 12:48
@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d56463e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf19d89c-b7e4-4a4b-941c-9f3c47c857bd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When 2 Ledger devices are both unlocked with Eth app open, MM displays the wrong account list
1 participant