Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): eth-json-rpc-filters@4.2.2->^5.1.0 #11975

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(deps): eth-json-rpc-filters@4.2.2->^5.1.0 #11975

merged 1 commit into from
Oct 23, 2024
+6 −24

Conversation

legobeat
Copy link
Contributor

Description

Bump eth-json-rpc-filters

Related issues

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eth-json-rpc-filters@5.1.0 None 0 27 kB gudahtt
npm/eth-json-rpc-middleware@4.3.0 None +2 120 kB danfinlay

🚮 Removed packages: npm/eth-json-rpc-filters@4.2.2, npm/eth-json-rpc-middleware@6.0.0

View full report↗︎

@legobeat legobeat added team-security Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@legobeat legobeat changed the title deps: eth-json-rpc-filters@4.2.2->^5.1.0 fix(deps): eth-json-rpc-filters@4.2.2->^5.1.0 Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5d7c57f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9eee4d4-f18a-48ef-9a6f-ebf8f47af9d2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 23, 2024
@legobeat legobeat marked this pull request as ready for review October 23, 2024 11:35
@legobeat legobeat requested review from a team as code owners October 23, 2024 11:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tommasini
tommasini approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only breaking change is the node version am I right?

@legobeat
Copy link
Contributor Author

Only breaking change is the node version am I right?

Correct!

@legobeat legobeat added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit a533326 Oct 23, 2024
36 of 37 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-filters-5 branch October 23, 2024 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-lavamoat team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @tommasini @metamaskbot