Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 #11979

wants to merge 8 commits into from
+317 −301

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 23, 2024 •
edited
Loading

Description

Replaces legacy ethereumjs-util with maintained @ethereumjs/util.

Related issues

Based on

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-lavamoat labels Oct 23, 2024
@legobeat legobeat changed the title deps: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 fix ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 Oct 23, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/bn.js@5.1.6 None 0 13.9 kB types

🚮 Removed packages: npm/@types/bn.js@5.1.5, npm/bindings@1.5.0, npm/bip66@1.1.5, npm/drbg.js@1.0.1, npm/file-uri-to-path@1.0.0

View full report↗︎

@legobeat legobeat changed the title fix ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 fix: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 Oct 23, 2024
@legobeat legobeat mentioned this pull request Oct 23, 2024
Open
8 tasks
@MetaMask MetaMask deleted a comment from github-actions bot Oct 23, 2024
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 88144dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9aee9078-b4fe-4249-ac78-c02e266e4b86

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a6e2bb1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e925c1a0-778f-4171-94ce-b2edbfbd7e81

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat marked this pull request as ready for review October 25, 2024 01:08
@legobeat legobeat requested review from a team as code owners October 25, 2024 01:08
@legobeat legobeat requested a review from a team as a code owner October 25, 2024 01:08
@legobeat legobeat changed the title fix: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 fix: ethereumjs-util -> @ethereumjs/util@^8.1.0 Oct 25, 2024
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 391bceb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44327d46-1f3a-4e6a-8402-666a10ff931d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat