Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Detox: add video recording on failure #11987

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Oct 23, 2024

Description

Right now, Detox does a good job of capturing screenshots when a test fails. But what we really need is the ability to provide engineers with video recordings that show exactly what happened leading up to a failure. This would give a clearer picture, making it easier to diagnose and fix issues by seeing the interactions and events in real-time, rather than trying to piece things together from a single snapshot.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Recording of test failure on iOS
https://github.com/user-attachments/assets/0efe7e3c-2366-4b89-bbaf-4eb4ad7e1cc7

Recording of test failure on android

test.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Oct 23, 2024
@cortisiko cortisiko self-assigned this Oct 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.24%. Comparing base (9f72156) to head (dd1e8d3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11987      +/-   ##
==========================================
+ Coverage   55.12%   55.24%   +0.11%     
==========================================
  Files        1752     1760       +8     
  Lines       39563    39705     +142     
  Branches     4922     4944      +22     
==========================================
+ Hits        21811    21936     +125     
- Misses      16249    16263      +14     
- Partials     1503     1506       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e2c8210
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06ff92dc-3241-4813-88ac-7cb98fa6669b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cortisiko cortisiko marked this pull request as ready for review October 23, 2024 23:18
@cortisiko cortisiko requested review from a team as code owners October 23, 2024 23:18
tommasini
tommasini previously approved these changes Oct 23, 2024
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ef71be2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f61f2b2-e399-4cc9-bbab-af618f820625

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 24, 2024

@cortisiko cortisiko added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit ea176e9 Oct 24, 2024
43 checks passed
@cortisiko cortisiko deleted the detox/add-video-recording-on-failure branch October 24, 2024 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 24, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants