-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix/10812 redundant source map upload #11993
Conversation
…0812-redundant-source-map-upload
This reverts commit 2cbd1e4.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 267bbd7 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks Cal for this!
Description
This PR introduces two new workflows in Bitrise
build_android_release_and_upload_sourcemaps
- Runsbuild_android_release
and uploads sourcemaps to Sentrybuild_ios_release_and_upload_sourcemaps
- Runsbuild_ios_release
and uploads sourcemaps to SentryBy default, both
build_android_release
andbuild_ios_release
will not automatically upload sourcemaps to SentryRelated PR - #11490
Related issues
Fixes: #10812
Manual testing steps
To build release AND upload sourcemaps, use the two workflows in Bitrise:
build_android_release_and_upload_sourcemaps
build_ios_release_and_upload_sourcemaps
To only build release without uploading sourcemaps, use the two workflows in Bitrise:
build_android_release
build_ios_release
Screenshots/Recordings
Before
After
In this test, we ran the default
build_ios_release
andbuild_android_release
, which resulted in no sourcemaps being uploadedIn this test, we enabled Sentry sourcemap upload and re-used
build_ios_release
andbuild_android_release
to mimic the workflows that uploads sourcemaps. We can see in the two builds that it successfully uploads sourcemaps.Sourcemaps uploaded
Pre-merge author checklist
Pre-merge reviewer checklist