fix: Fix/10812 redundant source map upload

[Cal-L]

Description

This PR introduces two new workflows in Bitrise

• build_android_release_and_upload_sourcemaps - Runs build_android_release and uploads sourcemaps to Sentry
• build_ios_release_and_upload_sourcemaps - Runs build_ios_release and uploads sourcemaps to Sentry

By default, both build_android_release and build_ios_release will not automatically upload sourcemaps to Sentry

Related PR - #11490

Related issues

Fixes: #10812

Manual testing steps

To build release AND upload sourcemaps, use the two workflows in Bitrise:

• build_android_release_and_upload_sourcemaps
• build_ios_release_and_upload_sourcemaps

To only build release without uploading sourcemaps, use the two workflows in Bitrise:

• build_android_release
• build_ios_release

Screenshots/Recordings

Before

After

In this test, we ran the default build_ios_release and build_android_release, which resulted in no sourcemaps being uploaded

• Android - https://app.bitrise.io/build/bc568645-d1e4-418c-bea0-6aafe8f2e21c
• iOS - https://app.bitrise.io/build/e7c224b3-c0f3-4be9-afa0-b3ad423d0da7

In this test, we enabled Sentry sourcemap upload and re-used build_ios_release and build_android_release to mimic the workflows that uploads sourcemaps. We can see in the two builds that it successfully uploads sourcemaps.

• Android - https://app.bitrise.io/build/d93989e0-3ca8-4bab-aaf2-48b0ca104986
• iOS - https://app.bitrise.io/build/b24edfed-b020-4ac1-bf44-191d284b099b

Sourcemaps uploaded

• Android:

- iOS:

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 267bbd7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c801fe5c-e327-4fcc-af4e-519c94f90a37

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[NicolasMassart]

Looks good to me. Thanks Cal for this!