Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix/10812 redundant source map upload #11993

Merged
merged 8 commits into from
Oct 24, 2024
+16 −6
Merged

fix: Fix/10812 redundant source map upload #11993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f49ee8
Create workflows to upload sourcemaps
Cal-L Oct 23, 2024
fdcf71f
Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix/1…
Cal-L Oct 23, 2024
4d794d8
Bump version to 1464
Cal-L Oct 23, 2024
ab5a3c6
Test uploading source maps
Cal-L Oct 24, 2024
2cbd1e4
Bump version number
Cal-L Oct 24, 2024
e3c00fe
Revert "Bump version number"
Cal-L Oct 24, 2024
1d5f2dc
Revert version bump
Cal-L Oct 24, 2024
267bbd7
Remove SENTRY_DISABLE_AUTO_UPLOAD for testing
Cal-L Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions bitrise.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ stages:
- run_tag_smoke_core_android: {}
build_regression_e2e_ios_android_stage:
workflows:
- ios_e2e_build: {}
- android_e2e_build: {}
- ios_e2e_build: {}
- android_e2e_build: {}
run_regression_e2e_ios_android_stage:
workflows:
- ios_run_regression_tests: {}
Expand Down Expand Up @@ -1094,6 +1094,11 @@ workflows:
bitrise.io:
stack: linux-docker-android-22.04
machine_type_id: elite-xl
build_android_release_and_upload_sourcemaps:
Cal-L marked this conversation as resolved.
Show resolved Hide resolved
envs:
- SENTRY_DISABLE_AUTO_UPLOAD: 'false'
after_run:
- build_android_release
build_android_qa:
before_run:
- code_setup
Expand Down Expand Up @@ -1264,7 +1269,7 @@ workflows:
- ipa_path: $BITRISE_APP_STORE_IPA_PATH
build_ios_release:
envs:
- NO_FLIPPER: '1'
- NO_FLIPPER: '1'
before_run:
- code_setup
after_run:
Expand Down Expand Up @@ -1303,9 +1308,14 @@ workflows:
- pipeline_intermediate_files: sourcemaps/ios/index.js.map:BITRISE_APP_STORE_SOURCEMAP_PATH
- deploy_path: sourcemaps/ios/index.js.map
title: Deploy Source Map
build_ios_release_and_upload_sourcemaps:
Cal-L marked this conversation as resolved.
Show resolved Hide resolved
envs:
- SENTRY_DISABLE_AUTO_UPLOAD: 'false'
after_run:
- build_ios_release
build_ios_qa:
envs:
- NO_FLIPPER: '1'
- NO_FLIPPER: '1'
before_run:
- code_setup
after_run:
Expand Down
4 changes: 2 additions & 2 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ buildIosRelease(){
remapEnvVariableRelease

# Enable Sentry to auto upload source maps and debug symbols
export SENTRY_DISABLE_AUTO_UPLOAD="false"
Cal-L marked this conversation as resolved.
Show resolved Hide resolved
export SENTRY_DISABLE_AUTO_UPLOAD=${SENTRY_DISABLE_AUTO_UPLOAD:-"true"}

prebuild_ios

Expand Down Expand Up @@ -426,7 +426,7 @@ buildAndroidRelease(){
fi

# Enable Sentry to auto upload source maps and debug symbols
export SENTRY_DISABLE_AUTO_UPLOAD="false"
export SENTRY_DISABLE_AUTO_UPLOAD=${SENTRY_DISABLE_AUTO_UPLOAD:-"true"}
prebuild_android

# GENERATE APK
Expand Down
Loading