Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick #11977 #12005

Draft
wants to merge 2 commits into
base: release/7.34.0
Choose a base branch
from

Commits on Oct 24, 2024

  1. chore: add tags to custom spans (#11977)

    ## **Description**
    
    Cherry-picked this
    [PR](#11623)
    
    Android build:
    https://app.bitrise.io/build/3cf918b6-a0b8-4a46-a3e8-78ebd74b9006
    
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [ ] I’ve followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
    Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Aslau Mario-Daniel <marioaslau@gmail.com>
    # Conflicts:
    #	app/store/index.ts
    #	app/util/trace.ts
    tommasini authored and NicolasMassart committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b39de88 View commit details
    Browse the repository at this point in the history
  2. retrigger checks

    NicolasMassart committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    174ba31 View commit details
    Browse the repository at this point in the history