Commits on Oct 24, 2024

1. fix: prevent Duplicate Block Explorer Entries and Ensure Proper Input… …

   … Validation (#11995)
   
   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   ## **Description**
   
   When editing a network and attempting to add a new block explorer URL,
   the 'Add Block Explorer URL +' button allows users to add a duplicate
   entry even if no input is provided. This results in duplicate block
   explorer URLs being added to the list. The expected behavior is that the
   'Add Block Explorer URL' button should remain disabled until valid input
   is provided, and existing URLs should not be re-added.
   
   <!--
   Write a short description of the changes included in this pull request,
   also include relevant motivation and context. Have in mind the following
   questions:
   1. What is the reason for the change?
   2. What is the improvement/solution?
   -->
   
   ## **Related issues**
   
   Fixes: #11990 
   
   ## **Manual testing steps**
   
   1. Go to network add form
   2. go to add block explorer url
   3. The 'Add Block Explorer URL' button should be disabled until a valid
   URL is inputted into the field.
   
   ## **Screenshots/Recordings**
   
   <!-- If applicable, add screenshots and/or recordings to visualize the
   before and after of your change. -->
   
   ### **Before**
   
   <!-- [screenshots/recordings] -->
   
   ### **After**
   
   
   
   https://github.com/user-attachments/assets/05f72bf8-8046-40a4-a941-51f39cfc9a09
   
   
   
   
   <!-- [screenshots/recordings] -->
   
   ## **Pre-merge author checklist**
   
   - [x] I’ve followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
   Coding
   Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
   - [x] I've completed the PR template to the best of my ability
   - [x] I’ve included tests if applicable
   - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [x] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   ## **Pre-merge reviewer checklist**
   
   - [ ] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.

   

   salimtb authored and metamaskbot committed Oct 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 26e02ce
   • Browse repository at this point

   Copy the full SHA

   26e02ce View commit details

   Browse the repository at this point in the history

2. retrigger checks

   

   salimtb committed Oct 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5e1a53c
   • Browse repository at this point

   Copy the full SHA

   5e1a53c View commit details

   Browse the repository at this point in the history