-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: toBignumber conversion error with high balance #12010
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: fc7623c Note
|
Do you have a link (or would you be able to describe in PR description) the issue this fixes? Considering if this is related at all to solving it: Also, is there any possible way to add a regression test for this bugfix? |
@@ -50,7 +51,10 @@ const useBalance = () => { | |||
); | |||
|
|||
const { pooledStakesData } = usePooledStakes(); | |||
const assets = pooledStakesData.assets ?? 0; | |||
const assets = useMemo( | |||
() => new BN(pooledStakesData.assets), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we can use hexToBN
from @metamask/controller-utils
if possible
Quality Gate passedIssues Measures |
Description
There is a bignumber conversion attempt which is failing, this change fixes this.
Related issues
Fixes: STAKE-848
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist