From fc7623c82c494f7bdddd4fdcd4d762e862aae3fd Mon Sep 17 00:00:00 2001 From: siibars <9662464+siibars@users.noreply.github.com> Date: Thu, 24 Oct 2024 19:11:34 +0200 Subject: [PATCH 1/3] fix: toBignumber conversion error with high balance --- app/components/UI/Stake/hooks/useBalance.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/components/UI/Stake/hooks/useBalance.ts b/app/components/UI/Stake/hooks/useBalance.ts index a96c9b6b39b..796d7aa775f 100644 --- a/app/components/UI/Stake/hooks/useBalance.ts +++ b/app/components/UI/Stake/hooks/useBalance.ts @@ -15,6 +15,7 @@ import { weiToFiatNumber, } from '../../../../util/number'; import usePooledStakes from './usePooledStakes'; +import { BN } from 'ethereumjs-util'; const useBalance = () => { const accountsByChainId = useSelector(selectAccountsByChainId); @@ -50,8 +51,8 @@ const useBalance = () => { ); const { pooledStakesData } = usePooledStakes(); - const assets = pooledStakesData.assets ?? 0; - + const assets = pooledStakesData.assets ? new BN(pooledStakesData.assets) : new BN(0); + const formattedStakedBalanceETH = useMemo( () => `${renderFromWei(assets)} ETH`, [assets], From 9fd65c19a47ff8c1fbc3c9fcb4109315a1bb2c98 Mon Sep 17 00:00:00 2001 From: siibars <9662464+siibars@users.noreply.github.com> Date: Thu, 24 Oct 2024 19:36:24 +0200 Subject: [PATCH 2/3] fix: unit test --- app/components/UI/Stake/hooks/useBalance.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/components/UI/Stake/hooks/useBalance.ts b/app/components/UI/Stake/hooks/useBalance.ts index 796d7aa775f..04e61637143 100644 --- a/app/components/UI/Stake/hooks/useBalance.ts +++ b/app/components/UI/Stake/hooks/useBalance.ts @@ -51,7 +51,7 @@ const useBalance = () => { ); const { pooledStakesData } = usePooledStakes(); - const assets = pooledStakesData.assets ? new BN(pooledStakesData.assets) : new BN(0); + const assets = new BN(pooledStakesData.assets); const formattedStakedBalanceETH = useMemo( () => `${renderFromWei(assets)} ETH`, @@ -73,7 +73,7 @@ const useBalance = () => { balanceFiat, balanceWei, balanceFiatNumber, - stakedBalanceWei: assets, + stakedBalanceWei: pooledStakesData.assets ?? '0', formattedStakedBalanceETH, stakedBalanceFiatNumber, formattedStakedBalanceFiat, From 3c7f559ab3c60971b452a75b31625a3644d686fb Mon Sep 17 00:00:00 2001 From: siibars <9662464+siibars@users.noreply.github.com> Date: Thu, 24 Oct 2024 19:40:19 +0200 Subject: [PATCH 3/3] chore: fix lint --- app/components/UI/Stake/hooks/useBalance.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/components/UI/Stake/hooks/useBalance.ts b/app/components/UI/Stake/hooks/useBalance.ts index 04e61637143..6054a7cad37 100644 --- a/app/components/UI/Stake/hooks/useBalance.ts +++ b/app/components/UI/Stake/hooks/useBalance.ts @@ -51,8 +51,11 @@ const useBalance = () => { ); const { pooledStakesData } = usePooledStakes(); - const assets = new BN(pooledStakesData.assets); - + const assets = useMemo( + () => new BN(pooledStakesData.assets), + [pooledStakesData], + ); + const formattedStakedBalanceETH = useMemo( () => `${renderFromWei(assets)} ETH`, [assets],