Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(11895): remove duplicate networks in incoming transactions settings #12016

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

Description

We now list mainnet networks in the RPC urls so the previous logic rendering mainnet is no longer need. Here is the relevant PR that has those changes

Related issues

Related Issue: #11895

Manual testing steps

  1. Go to this settings page
  2. Click on "Security & Privacy"
  3. Scroll down and toggle "Show incoming transactions" and confirm that it works
  4. Confirm that the duplicate mainnet networks are gone

Screenshots/Recordings

incoming_transactions

Before After
Simulator Screenshot - iPhone 16 Pro Max - 2024-10-24 at 13 37 34 Simulator Screenshot - iPhone 16 Pro Max - 2024-10-24 at 13 36 43

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested a review from a team as a code owner October 24, 2024 19:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 24, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 69cae3b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/446ee62e-a4c2-4a38-a2c3-0961becdf962

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4af32bf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/210b109c-b252-4b05-abe8-e59101ca2229

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6b5b819
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db92871f-8d5c-4dae-9078-eb24702615bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 24, 2024

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app security indicates that 'Mainnet' is not the right name. Expected that the default network name matches suggested name and is aligned with security checks. We can get PM input if needed.

screenshot-1729802892586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants