Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 #12024

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 #12024

wants to merge 2 commits into from
+18 −18

Conversation

legobeat
Copy link
Contributor

Description

Replace deprecated eth-json-rpc-filters with @metamask/eth-json-rpc-filters.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat changed the title deps: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 chore eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 Oct 25, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 25, 2024
@legobeat legobeat changed the title chore eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 Oct 25, 2024
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-filters@8.0.0 None 0 24.4 kB lgbot

🚮 Removed packages: npm/eth-json-rpc-filters@6.0.1

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8c971a8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e31c470-67c0-47c1-9103-0412b7e29c3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat marked this pull request as ready for review October 25, 2024 03:09
@legobeat legobeat requested review from a team as code owners October 25, 2024 03:10
@legobeat legobeat mentioned this pull request Oct 25, 2024
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-security team-wallet-framework
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@legobeat