Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs in add network modal #12907

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Jan 8, 2025

Description

Fixes 2 bugs in the add network modal:

  • When clicking the "Review" button to compare the old vs new RPC urls, the new url was hardcoded to https://flashbots.polygon-mainnet.com here. This code seems WIP code, but got shipped to prod. For now I have disabled this Review button until the actual data can be passed into the component.
Screen.Recording.2025-01-08.at.12.13.01.PM.mov
  • When adding a popular network, it would say You're adding this network to MetaMask and giving Undefined dapp origin permission to use it.. This message should only appear when dapps add networks, not when adding from the popular list.

Related issues

Fixes: #12492

Manual testing steps

Screenshots/Recordings

Before

Screen.Recording.2025-01-08.at.1.06.41.PM.mov

After

Screen.Recording.2025-01-08.at.1.05.03.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner January 8, 2025 21:08
@bergeron bergeron requested a review from EtherWizard33 January 8, 2025 21:09
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. and removed team-assets labels Jan 8, 2025
@bergeron bergeron requested a review from a team as a code owner January 8, 2025 21:46
Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect message when adding network from Popular list
2 participants