fix: bugs in add network modal #12907
Open
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes 2 bugs in the add network modal:
https://flashbots.polygon-mainnet.com
here. This code seems WIP code, but got shipped to prod. For now I have disabled this Review button until the actual data can be passed into the component.Screen.Recording.2025-01-08.at.12.13.01.PM.mov
You're adding this network to MetaMask and giving Undefined dapp origin permission to use it.
. This message should only appear when dapps add networks, not when adding from the popular list.Related issues
Fixes: #12492
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-01-08.at.1.06.41.PM.mov
After
Screen.Recording.2025-01-08.at.1.05.03.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist