Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockaid banners implementation #6585

Merged
merged 41 commits into from
Aug 24, 2023
Merged

Blockaid banners implementation #6585

merged 41 commits into from
Aug 24, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Jun 12, 2023 •
edited
Loading

Description
Implementing the Blockaid Banner and making it configurable, such that we only pass in the attackType and attackDetails as props.

This will allow us to be able to show BlockAid PPOM error/warning messages.

Fixes: https://github.com/metamask/metamask-planning/issues/396

Screenshots
Screenshot 2023-07-28 at 07 22 10

Screenshot 2023-07-28 at 07 22 21

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@segun segun requested a review from a team as a code owner June 12, 2023 10:05
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun force-pushed the blockaid-banners-implementation branch from 599ee10 to 4442102 Compare June 12, 2023 10:06
Base automatically changed from blockaid-banners to main June 19, 2023 10:53
@segun segun force-pushed the blockaid-banners-implementation branch from 56519ab to 3db01b6 Compare June 19, 2023 11:01
@segun segun self-assigned this Jun 22, 2023
@segun segun added team-confirmations-secure-ux-PR PR from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 22, 2023
jpuri
jpuri reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, but I added small possible improvements.

@segun segun force-pushed the blockaid-banners-implementation branch from 3db01b6 to a2a31cc Compare June 26, 2023 11:34
@segun segun requested a review from jpuri June 27, 2023 04:43
@segun segun force-pushed the blockaid-banners-implementation branch from 79d8220 to 3b1265b Compare June 28, 2023 10:05
@segun segun force-pushed the blockaid-banners-implementation branch from 3b1265b to 75d04be Compare July 18, 2023 08:22
blackdevelopa
blackdevelopa previously approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. Left a couple small nit

@segun segun force-pushed the blockaid-banners-implementation branch from 927ca3c to 9c0f01a Compare July 20, 2023 15:55
segun added 14 commits August 4, 2023 14:46
@segun
changes to make it look good when added to transaction page
41ab826
@segun
margin between lines to make it look like figma
6e01e02 
sorted en.json alphabetically

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
Use security tick
bf8dbde 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
Fix snapshot
ffc124e 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
rename blockaid
6bd01d9 
rename shield -> security tick

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
snapshot fix
efabe87
@segun
Fix PR comments.
5bcbdd5 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
fall back to others as reason for non existent reason
3bdcb5a 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
For failed Response, show a normal banner alert
648506d 
Capitalize reasons
Tests

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
Fix snapshot and test titles
bb0de2b
@segun
do not show blockaid if no env. variable
76d605b 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
lint fix
e33e442
@segun
move Accordion into renderDetails to avoid rendering if no details ar…
316e30c 
…e provided
@segun
Add title for failed
3ec9aa5 
refactor code
@segun segun force-pushed the blockaid-banners-implementation branch from 8fa2a8c to 3ec9aa5 Compare August 4, 2023 13:47
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

jpuri
jpuri approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschorchit bschorchit added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 22, 2023
@jpuri jpuri removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 24, 2023
@jpuri jpuri dismissed brianacnguyen’s stale review August 24, 2023 10:15

Changes have been implemented

@jpuri jpuri merged commit 0799d7c into main Aug 24, 2023
12 of 14 checks passed
@jpuri jpuri deleted the blockaid-banners-implementation branch August 24, 2023 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpuri jpuri jpuri approved these changes

@digiwand digiwand digiwand approved these changes

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

@blackdevelopa blackdevelopa Awaiting requested review from blackdevelopa

@brianacnguyen brianacnguyen Awaiting requested review from brianacnguyen

Assignees

@segun segun

Labels
release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@segun @jpuri @brianacnguyen @digiwand @blackdevelopa @bschorchit @metamaskbot