-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockaid banners implementation #6585
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
599ee10
to
4442102
Compare
56519ab
to
3db01b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, but I added small possible improvements.
3db01b6
to
a2a31cc
Compare
79d8220
to
3b1265b
Compare
3b1265b
to
75d04be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good. Left a couple small nit
927ca3c
to
9c0f01a
Compare
app/components/UI/BlockaidBanner/__snapshots__/BlockaidBanner.test.tsx.snap
Outdated
Show resolved
Hide resolved
sorted en.json alphabetically Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
rename shield -> security tick Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Capitalize reasons Tests Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
refactor code
8fa2a8c
to
3ec9aa5
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs 75.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implementing the Blockaid Banner and making it configurable, such that we only pass in the attackType and attackDetails as props.
This will allow us to be able to show BlockAid PPOM error/warning messages.
Fixes: https://github.com/metamask/metamask-planning/issues/396
Screenshots
Checklist