-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(on-ramp): refactor quotes screen #6615
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
07c697b
to
7d2f37b
Compare
7d2f37b
to
54c7e7c
Compare
8c88a82
to
319205c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wachunei LGTM I finished verifying this change |
@sethkfman your review was dismissed but there are no changes 🤔 not sure what happened |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Closed in favor of #6804 |
Closed due to CI not updating. Another ticket was opened but this provides the review history. |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR refactors the Quotes screen of the on-ramp with a new design and file structure.
Screenshots/Recordings
Before:
sim_before.mp4
After:
sim.mp4
Issue
Progresses #???
Checklist