refactor(on-ramp): refactor quotes screen #6615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
added
team-ramp
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
wachunei
force-pushed
the
feature/onramp-quotes-fiat-rate
branch
6 times, most recently
from
07c697b
to
7d2f37b
Compare
wachunei
force-pushed
the
feature/onramp-quotes-fiat-rate
branch
from
7d2f37b
to
54c7e7c
Compare
wachunei
force-pushed
the
feature/onramp-quotes-fiat-rate
branch
from
8c88a82
to
319205c
Compare
wachunei
added
the
release-7.4.0
|
@wachunei LGTM I finished verifying this change |
wachunei
added
QA Passed
|
@sethkfman your review was dismissed but there are no changes 🤔 not sure what happened |
wachunei
removed
the
needs-dev-review
sethkfman
previously approved these changes
Jul 13, 2023
sethkfman
previously approved these changes
Jul 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Closed in favor of #6804 |
|
Closed due to CI not updating. Another ticket was opened but this provides the review history. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR refactors the Quotes screen of the on-ramp with a new design and file structure.
Screenshots/Recordings
Before:
sim_before.mp4
After:
sim.mp4
Issue
Progresses #???
Checklist