refactor: Use Redux network controller state #6686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
use-selectors-for-network-controller-state-access
branch
4 times, most recently
from
7ef0fa0
to
8c2d0e3
Compare
Base automatically changed from
use-selectors-for-network-controller-state-access
to
main
June 29, 2023 00:17
Gudahtt
force-pushed
the
replace-direct-network-state-references
branch
from
4d24da9
to
4f92edd
Compare
Gudahtt
added
needs-dev-review
Gudahtt
force-pushed
the
replace-direct-network-state-references
branch
from
4f92edd
to
be54525
Compare
Various UI components have been updated to use Redux network controller state (via selectors) rather than directly accessing the controller state using the `Engine` global. Relates to MetaMask/mobile-planning#1016
Gudahtt
force-pushed
the
replace-direct-network-state-references
branch
from
cf83960
to
73f6413
Compare
|
I have broken out the less complex changes into #6848, and I'll close this. The remaining pieces are the four signature components, which aren't easy to add selectors to without refactoring the unit tests to use react testing library first, so I'll pursue that separately. |
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Various UI components have been updated to use Redux network controller state (via selectors) rather than directly accessing the controller state using the
Engineglobal.Issue
Relates to MetaMask/mobile-planning#1016
Checklist