-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing wallet_requestPermissions
and wallet_getPermissions
to the mobile API.
#6732
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
wallet_requestPermissions
and wallet_getPermissions
to the mobile API.
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
e41f734
to
44b66f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e4a1578
to
417b956
Compare
417b956
to
dce772c
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added missing methods
wallet_requestPermissions
andwallet_getPermissions
to the mobile API.This brings it in line with the extension API so that dapps that build against requestPermissions don't have to have extra logic to do
requestAccounts
instead.fixes https://github.com/MetaMask/MetaMask-planning/issues/861
Screenshots/Recordings
some screenshots of it working in the new api playground:
wallet_requestPermissions
error case:
wallet_getPermissions