Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MMPD-546): update portfolio icon #6751

Closed
wants to merge 9 commits into from

Conversation

GuiBibeau
Copy link
Contributor

@GuiBibeau GuiBibeau commented Jul 6, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Due to a redesign, we are changing the link to portfolio from a simple icon to instead be a secondary button.

Screenshots/Recordings

Screenshot 2023-07-06 at 12 52 45 PM Screenshot 2023-07-12 at 4 47 40 PM

How to test:

  1. Go to the main view
  2. click the portfolio button and make sure the portfolio link works like before

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 6, 2023
@sethkfman
Copy link
Contributor

@yanrong-chen Can you take a look at the UI above to make sure it is aligned with platform design?

@GuiBibeau
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yanrong-chen
Copy link

@yanrong-chen Can you take a look at the UI above to make sure it is aligned with platform design?

Hi Seth, we are using a different icon in this portfolio entry button
portfolio entry(1)

@jclancy93
Copy link
Contributor

LGTM from the portfolio side

jclancy93
jclancy93 previously approved these changes Jul 6, 2023
@GuiBibeau
Copy link
Contributor Author

@yanrong-chen @sethkfman I'm currently waiting to get Figma access to have the right account to put here. I left a comment on this in the PR description.
#6751 (comment)

@yanrong-chen
Copy link

@yanrong-chen @sethkfman I'm currently waiting to get Figma access to have the right account to put here. I left a comment on this in the PR description. #6751 (comment)

I moved this design to the following link, pls let me know if you still can't access the page
https://www.figma.com/file/fFuWPCTvJ9ZYHIxFyRq0HH/portfolio-entry?type=design&node-id=0-1&mode=design&t=ayqoKxzA7R2vFqu3-0

change icon
@GuiBibeau
Copy link
Contributor Author

@yanrong-chen @sethkfman I'm currently waiting to get Figma access to have the right account to put here. I left a comment on this in the PR description. #6751 (comment)

I moved this design to the following link, pls let me know if you still can't access the page https://www.figma.com/file/fFuWPCTvJ9ZYHIxFyRq0HH/portfolio-entry?type=design&node-id=0-1&mode=design&t=ayqoKxzA7R2vFqu3-0

Thanks that gave me the name! I updated the code and screenshot

@yanrong-chen
Copy link

Hi @GuiBibeau - The new screenshot looks great to me! Thank you for the fix.

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@GuiBibeau GuiBibeau requested a review from a team as a code owner July 12, 2023 13:38
@GuiBibeau GuiBibeau added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Jul 12, 2023
@GuiBibeau GuiBibeau closed this Jul 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants