-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MMPD-546): update portfolio icon #6751
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@yanrong-chen Can you take a look at the UI above to make sure it is aligned with platform design? |
I have read the CLA Document and I hereby sign the CLA |
Hi Seth, we are using a different icon in this portfolio entry button |
LGTM from the portfolio side |
@yanrong-chen @sethkfman I'm currently waiting to get Figma access to have the right account to put here. I left a comment on this in the PR description. |
I moved this design to the following link, pls let me know if you still can't access the page |
change icon
Thanks that gave me the name! I updated the code and screenshot |
Hi @GuiBibeau - The new screenshot looks great to me! Thank you for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Due to a redesign, we are changing the link to portfolio from a simple icon to instead be a secondary button.
Screenshots/Recordings
How to test:
Issue
Progresses #???
Checklist