fix: update cookie-tough dependency #6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tommasini
added
needs-dev-review
tommasini
commented
Jul 10, 2023
tommasini
added
No QA Needed
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to solve vulnerabilities found
Vulnerability Found:
Severity: MODERATE
Modules: @metamask/network-controller>web3-provider-engine>request>tough-cookie, @metamask/assets-controllers>@metamask/network-controller>web3-provider-engine>request>tough-cookie
URL: GHSA-72xf-g2v4-qvf3
Vulnerability Found:
Severity: MODERATE
Modules: @metamask/network-controller>web3-provider-engine>request>tough-cookie, @metamask/assets-controllers>@metamask/network-controller>web3-provider-engine>request>tough-cookie
URL: GHSA-72xf-g2v4-qvf3
Screenshots/Recordings
Wallet with zero balance changing networks:
https://recordit.co/ZuOnh6Z14H
Imported account -> imported tokens, imported nfts (automatically and manually)
https://recordit.co/f09WdFAkW6 (import nft manually)
https://recordit.co/9TWRuGY56I
Transactions (e2e test dapp, send flow and almost swap on uniswap)
https://recordit.co/Hx921Okotm
E2E QA:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5caec38-1f19-4536-b180-3541cf4cda40
Issue
Progresses #???
Checklist