-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use selectors for preferences controller state access #6775
refactor: Use selectors for preferences controller state access #6775
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll start the e2e tests
e2ff8ac
to
7f9e507
Compare
Looks like there are new conflicts on this one |
7f9e507
to
022f47f
Compare
I just did a rebase |
e7ab082
to
cc85194
Compare
Failed test run here: https://app.bitrise.io/build/c51da20e-ac10-4f37-8964-b3810a133dd6 |
3623cd9
to
5918c46
Compare
5918c46
to
a19d9e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Kudos, SonarCloud Quality Gate passed! |
Description
Preferences controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to PreferencesController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1017
Checklist