refactor: Use selectors for preferences controller state access #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
added
the
No QA Needed
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
previously approved these changes
Jul 10, 2023
cryptodev-2s
force-pushed
the
use-selectors-for-preferences-controllers-state-access
branch
from
e2ff8ac
to
7f9e507
Compare
|
Looks like there are new conflicts on this one |
cryptodev-2s
force-pushed
the
use-selectors-for-preferences-controllers-state-access
branch
from
7f9e507
to
022f47f
Compare
I just did a rebase |
Gudahtt
previously approved these changes
Jul 13, 2023
cryptodev-2s
force-pushed
the
use-selectors-for-preferences-controllers-state-access
branch
from
e7ab082
to
cc85194
Compare
|
Failed test run here: https://app.bitrise.io/build/c51da20e-ac10-4f37-8964-b3810a133dd6 |
Gudahtt
reviewed
Jul 13, 2023
mcmire
reviewed
Jul 13, 2023
cryptodev-2s
force-pushed
the
use-selectors-for-preferences-controllers-state-access
branch
3 times, most recently
from
3623cd9
to
5918c46
Compare
mcmire
reviewed
Jul 20, 2023
cryptodev-2s
force-pushed
the
use-selectors-for-preferences-controllers-state-access
branch
from
5918c46
to
a19d9e2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mcmire
approved these changes
Jul 20, 2023
cryptodev-2s
deleted the
use-selectors-for-preferences-controllers-state-access
branch
metamaskbot
added
the
release-7.5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preferences controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to PreferencesController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1017
Checklist