Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wc2 dependencies update and handle switchNetwork #6782

Merged
merged 11 commits into from
Jul 13, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Jul 11, 2023

Description

  • add redirect metadata into wallet connect core instance
  • handle wallet_switchNetwork call to prevent returning response until user modal has onboarded

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team labels Jul 11, 2023
@socket-security
Copy link

socket-security bot commented Jul 11, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@walletconnect/react-native-compat 2.7.6...2.9.0 None +0/-0 12.4 kB gancho_walletconnect
@walletconnect/se-sdk 1.4.0...1.5.0 network +2/-6 7.11 MB gancho_walletconnect

🚮 Removed packages: @walletconnect/types@2.7.3

@abretonc7s abretonc7s marked this pull request as ready for review July 11, 2023 12:26
@christopherferreira9 christopherferreira9 added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 11, 2023
andreahaku
andreahaku previously approved these changes Jul 11, 2023
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 11, 2023
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 11, 2023
@andreahaku andreahaku added the release-7.4.0 Issue or pull request that will be included in release 7.4.0 label Jul 11, 2023
@christopherferreira9 christopherferreira9 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jul 12, 2023
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Network access @walletconnect/se-sdk 1.5.0

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @walletconnect/se-sdk@1.5.0

andreahaku
andreahaku previously approved these changes Jul 12, 2023
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

7.5% 7.5% Coverage
0.0% 0.0% Duplication

@christopherferreira9 christopherferreira9 merged commit 61bee9c into main Jul 13, 2023
11 checks passed
@christopherferreira9 christopherferreira9 deleted the feat/wc2-update branch July 13, 2023 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.4.0 Issue or pull request that will be included in release 7.4.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants