Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MMPD-546): update portfolio icon #6795

Merged
merged 8 commits into from
Jul 13, 2023
Merged

feat(MMPD-546): update portfolio icon #6795

merged 8 commits into from
Jul 13, 2023

Conversation

GuiBibeau
Copy link
Contributor

Linked PR: #6751. Reopenning to trigger a build directly on repo instead of fork

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Due to a redesign, we are changing the link to portfolio from a simple icon to instead be a secondary button.

Screenshots/Recordings

Screenshot 2023-07-06 at 12 52 45 PM Screenshot 2023-07-12 at 4 47 40 PM

How to test:

  1. Go to the main view
  2. click the portfolio button and make sure the portfolio link works like before

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@GuiBibeau GuiBibeau requested a review from a team as a code owner July 12, 2023 21:06
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the title Update portfolio icon feat(MMPD-546): update portfolio icon Jul 12, 2023
sethkfman
sethkfman approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.4.0 Issue or pull request that will be included in release 7.4.0 labels Jul 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GuiBibeau GuiBibeau merged commit 0798f07 into main Jul 13, 2023
11 checks passed
@GuiBibeau GuiBibeau deleted the update-portfolio-icon branch July 13, 2023 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.4.0 Issue or pull request that will be included in release 7.4.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuiBibeau @sethkfman