Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test fixture for initial background state #6798

Merged
merged 2 commits into from
Jul 18, 2023
Merged

test: Add test fixture for initial background state #6798

merged 2 commits into from
Jul 18, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 13, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

A test fixture has been added for the initial background state. This fixture is kept up-to-date with a unit test. This will be used in future PRs to simplify unit test setup.

Issue

This was done to help with https://github.com/MetaMask/mobile-planning/issues/1016

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Gudahtt Gudahtt changed the title Add test fixture for initial background state test: Add test fixture for initial background state Jul 13, 2023
@Gudahtt Gudahtt force-pushed the add-initial-background-state-test-fixture branch from 1cbbaae to 8e4dfe7 Compare July 13, 2023 13:33
@Gudahtt Gudahtt marked this pull request as ready for review July 13, 2023 13:33
@Gudahtt Gudahtt requested a review from a team as a code owner July 13, 2023 13:33
@Gudahtt Gudahtt force-pushed the add-initial-background-state-test-fixture branch from 8e4dfe7 to 4f66109 Compare July 15, 2023 00:39
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 15, 2023
@Gudahtt Gudahtt force-pushed the add-initial-background-state-test-fixture branch from 4f66109 to 17d96b9 Compare July 17, 2023 20:56
Gudahtt
Gudahtt commented Jul 18, 2023
View reviewed changes
tsconfig.json Show resolved Hide resolved
@Gudahtt Gudahtt mentioned this pull request Jul 18, 2023
Merged
3 tasks
@Gudahtt
Add test fixture for initial background state
0d672af 
A test fixture has been added for the initial background state. This
fixture is kept up-to-date with a unit test. This will be used in
future PRs to simplify unit test setup.
@Gudahtt
Add one example of this background state being used
74d425d
@Gudahtt Gudahtt force-pushed the add-initial-background-state-test-fixture branch from 82db9e7 to 74d425d Compare July 18, 2023 17:35
Cal-L
Cal-L approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/util/test/initial-background-state.json Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Gudahtt Gudahtt added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 18, 2023
@Gudahtt Gudahtt merged commit 3841fc2 into main Jul 18, 2023
13 checks passed
@Gudahtt Gudahtt deleted the add-initial-background-state-test-fixture branch July 18, 2023 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
@metamaskbot metamaskbot added the release-7.5.0 Issue or pull request that will be included in release 7.5.0 label Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.5.0 Issue or pull request that will be included in release 7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @Cal-L @metamaskbot