-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add test fixture for initial background state #6798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
changed the title
Add test fixture for initial background state
test: Add test fixture for initial background state
Jul 13, 2023
Gudahtt
force-pushed
the
add-initial-background-state-test-fixture
branch
from
July 13, 2023 13:33
1cbbaae
to
8e4dfe7
Compare
Gudahtt
force-pushed
the
add-initial-background-state-test-fixture
branch
from
July 15, 2023 00:39
8e4dfe7
to
4f66109
Compare
Gudahtt
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Jul 15, 2023
Gudahtt
force-pushed
the
add-initial-background-state-test-fixture
branch
from
July 17, 2023 20:56
4f66109
to
17d96b9
Compare
Gudahtt
commented
Jul 18, 2023
Gudahtt
commented
Jul 18, 2023
3 tasks
A test fixture has been added for the initial background state. This fixture is kept up-to-date with a unit test. This will be used in future PRs to simplify unit test setup.
Gudahtt
force-pushed
the
add-initial-background-state-test-fixture
branch
from
July 18, 2023 17:35
82db9e7
to
74d425d
Compare
Cal-L
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Gudahtt
added
No QA Needed
Apply this label when your PR does not need any QA effort.
and removed
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Jul 18, 2023
metamaskbot
added
the
release-7.5.0
Issue or pull request that will be included in release 7.5.0
label
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.5.0
Issue or pull request that will be included in release 7.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
A test fixture has been added for the initial background state. This fixture is kept up-to-date with a unit test. This will be used in future PRs to simplify unit test setup.
Issue
This was done to help with https://github.com/MetaMask/mobile-planning/issues/1016
Checklist