Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prioritize resume over deeplink to accelerate reconnection flow #6799

Merged
merged 3 commits into from
Jul 13, 2023
Merged

feat: prioritize resume over deeplink to accelerate reconnection flow #6799

merged 3 commits into from
Jul 13, 2023

Conversation

abretonc7s
Copy link
Contributor

Description

Previously deeplink were prioritized to re-established connection which would interrupt the resume() call and re-create a full key exchange.
Now that the connection flow has been stabilized, re-enabled the resume call which greatly improve performance on android.

@abretonc7s abretonc7s requested a review from a team as a code owner July 13, 2023 05:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team release-7.4.0 Issue or pull request that will be included in release 7.4.0 labels Jul 13, 2023
andreahaku
andreahaku previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 13, 2023
@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jul 13, 2023
andreahaku
andreahaku approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s force-pushed the feat/sdk-resume-connection branch 2 times, most recently from f6b668c to 015d705 Compare July 13, 2023 14:26
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

39.4% 39.4% Coverage
0.0% 0.0% Duplication

@christopherferreira9 christopherferreira9 merged commit bb7c45a into main Jul 13, 2023
11 checks passed
@christopherferreira9 christopherferreira9 deleted the feat/sdk-resume-connection branch July 13, 2023 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
QA Passed A successful QA run through has been done release-7.4.0 Issue or pull request that will be included in release 7.4.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abretonc7s @andreahaku @christopherferreira9