Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.4.0 #6806

Merged
merged 12 commits into from
Jul 28, 2023
Merged

7.4.0 #6806

merged 12 commits into from
Jul 28, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 7.4.0.

@github-actions
Copy link
Contributor Author

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

wachunei and others added 10 commits July 17, 2023 11:42
@wachunei
fix: define ReactNativePayments podspec path in podfile (#6821)
a9aded3
@tommasini
from address changing on transaction object (#6841)
3cb0b45
@sethkfman @blackdevelopa
fix: invalid transaction data used for approve transaction (#6833) (#…
1e8e955 
…6842)

* use valid txn data when approving txn

* rename variable

Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
@vinistevam
add check approval request exists before rejecting (#6838)
499860f
@chrisleewilcox
build 1155 RC2 (#6861)
88ee868
@chrisleewilcox
fix(test): Permission Systems fix taping connect modals (#6868)
f5c102e 
* fix tapping connect modals

* fixed lint issues

* removed unused function, not referenced anywhere
@sethkfman @github-actions
chore: merge 7.3.1 cherry-pick (#6923)
2a9872b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sethkfman
chore: version bump for 7.4.0 RC 3 (#6924)
e4d64e2
@chrisleewilcox
build 1159 RC4 (#6928)
e128e67
@sethkfman
Merge branch 'main' into release/7.4.0
d79b189
@sethkfman sethkfman marked this pull request as ready for review July 28, 2023 21:07
@sethkfman sethkfman requested a review from a team as a code owner July 28, 2023 21:07
chrisleewilcox
chrisleewilcox approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added the QA Passed A successful QA run through has been done label Jul 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sethkfman sethkfman merged commit 4f5141a into main Jul 28, 2023
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Jul 28, 2023
@xinnanyemm xinnanyemm removed the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chrisleewilcox @sethkfman @metamaskbot @xinnanyemm @wachunei @tommasini @vinistevam