Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update button constants structure to prevent require cycle #6808

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix: Update button constants structure to prevent require cycle #6808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/component-library/components/Buttons/Button/Button.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,7 @@
import { SAMPLE_BUTTONSECONDARY_PROPS } from './variants/ButtonSecondary/ButtonSecondary.constants';

// Internal dependencies.
import {
ButtonSize,
ButtonWidthTypes,
ButtonProps,
ButtonVariants,
} from './Button.types';

// Defaults
export const DEFAULT_BUTTON_SIZE = ButtonSize.Md;
export const DEFAULT_BUTTON_WIDTH = ButtonWidthTypes.Auto;
import { ButtonProps, ButtonVariants } from './Button.types';

// Samples
export const SAMPLE_BUTTON_PROPS: ButtonProps = {
Expand Down
8 changes: 2 additions & 6 deletions ...component-library/components/Buttons/Button/foundation/ButtonBase/ButtonBase.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
/* eslint-disable no-console */
/* eslint-disable import/prefer-default-export */
// External dependencies.
import {
DEFAULT_BUTTON_SIZE,
DEFAULT_BUTTON_WIDTH,
} from '../../Button.constants';
import { ButtonBaseProps } from './ButtonBase.types';
import { IconName, IconSize } from '../../../../Icons/Icon';
import { ButtonSize, ButtonWidthTypes } from '../../Button.types';

// Defaults
export const DEFAULT_BUTTONBASE_SIZE = DEFAULT_BUTTON_SIZE;
export const DEFAULT_BUTTONBASE_WIDTH = DEFAULT_BUTTON_WIDTH;
export const DEFAULT_BUTTONBASE_SIZE = ButtonSize.Md;
export const DEFAULT_BUTTONBASE_WIDTH = ButtonWidthTypes.Auto;
export const DEFAULT_BUTTONBASE_ICON_SIZE = IconSize.Sm;

// Samples
Expand Down
Loading