-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use selectors for nft controller state access #6820
refactor: Use selectors for nft controller state access #6820
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
eaa0bf5
to
5ab41d0
Compare
5ab41d0
to
1916d2d
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I linked the issue to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Nft controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to NftController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1062
Checklist