test: Refactor unit test background state fixtures #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
changed the title
Gudahtt
force-pushed
the
add-initial-background-state-test-fixture
branch
from
82db9e7
to
74d425d
Compare
Gudahtt
force-pushed
the
refactor-unit-test-fixtures
branch
from
a5679c1
to
bb27190
Compare
Base automatically changed from
add-initial-background-state-test-fixture
to
main
July 18, 2023 18:20
Gudahtt
force-pushed
the
refactor-unit-test-fixtures
branch
from
bb27190
to
99c3254
Compare
Gudahtt
added
No QA Needed
All unit test background state fixtures have been updated to extend the initial background state fixture. Any background state modifications not necessary for tests to pass have been removed. This should dramatically reduce the burden of maintaining these fixtures, especially as we update our core packages.
Gudahtt
force-pushed
the
refactor-unit-test-fixtures
branch
from
99c3254
to
6e94698
Compare
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
added
release-7.5.0
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
All unit test background state fixtures have been updated to extend the initial background state fixture. Any background state modifications not necessary for tests to pass have been removed.
This should dramatically reduce the burden of maintaining these fixtures, especially as we update our core packages.
Issue
This was done to help with https://github.com/MetaMask/mobile-planning/issues/1016
Checklist