-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove fallback #6837
fix: Remove fallback #6837
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test what happens when NFT info fails to fetch from on chain AND fallback is removed?
Perfect. thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Description
Remove fallback, more information on this issue
Core pr
MetaMask/core#1532
Screenshots/Recordings
https://recordit.co/WW4TvM6fZ4
E2E test
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4088eeac-b0df-4e09-9e09-7202f292527f
Issue
Progresses #???
Checklist