Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove fallback #6837

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix: Remove fallback #6837

merged 3 commits into from
Jul 20, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jul 19, 2023 •
edited
Loading

Description
Remove fallback, more information on this issue

Core pr
MetaMask/core#1532

Screenshots/Recordings
https://recordit.co/WW4TvM6fZ4

E2E test
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4088eeac-b0df-4e09-9e09-7202f292527f

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner July 19, 2023 11:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 19, 2023
Cal-L
Cal-L approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cal-L
Cal-L requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test what happens when NFT info fails to fetch from on chain AND fallback is removed?

@tommasini
Copy link
Contributor Author

Hey @Cal-L the result of this test is here

@Cal-L
Copy link
Contributor

Cal-L commented Jul 20, 2023

Can we test what happens when NFT info fails to fetch from on chain AND fallback is removed?

Perfect. thank you

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. release-7.5.0 Issue or pull request that will be included in release 7.5.0 team-mobile-client and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 20, 2023
Cal-L
Cal-L approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tommasini tommasini merged commit f202dfd into main Jul 20, 2023
15 checks passed
@tommasini tommasini deleted the fix/822-remove-fallback branch July 20, 2023 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@gauthierpetetin gauthierpetetin added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 28, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. No QA Needed Apply this label when your PR does not need any QA effort. release-7.5.0 Issue or pull request that will be included in release 7.5.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommasini @Cal-L @gauthierpetetin