Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build 1155 RC2 #6861

Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat: Build 1155 RC2 #6861

merged 1 commit into from
Jul 21, 2023

Conversation

chrisleewilcox
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Build 1155 RC2

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-7.4.0 Issue or pull request that will be included in release 7.4.0 labels Jul 21, 2023
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner July 21, 2023 19:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug D 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 61 Code Smells

37.8% 37.8% Coverage
2.8% 2.8% Duplication

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 88ee868 into release/7.4.0 Jul 21, 2023
13 checks passed
@chrisleewilcox chrisleewilcox deleted the build_1155_RC2 branch July 21, 2023 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.4.0 Issue or pull request that will be included in release 7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants