Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update PR template to include QA labels. #6862

Merged
merged 4 commits into from
Jul 28, 2023
Merged

docs: update PR template to include QA labels. #6862

merged 4 commits into from
Jul 28, 2023

Conversation

cortisiko
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR aims to update the template, incorporating QA labels, to inform engineers about the usage and criteria for applying QA labels.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko cortisiko requested a review from a team as a code owner July 21, 2023 21:08
@cortisiko cortisiko added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Jul 21, 2023
Cal-L
Cal-L previously approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

NicolasMassart
NicolasMassart previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

@cortisiko cortisiko dismissed stale reviews from Cal-L and NicolasMassart via 7538f0d July 24, 2023 20:14
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cortisiko cortisiko merged commit 0772f32 into main Jul 28, 2023
11 checks passed
@cortisiko cortisiko deleted the update/pr-template-to-reflect-qa-labels branch July 28, 2023 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cryptotavares cryptotavares cryptotavares approved these changes

@NicolasMassart NicolasMassart NicolasMassart left review comments

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.6.0 Issue or pull request that will be included in release 7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cortisiko @NicolasMassart @Cal-L @cryptotavares @metamaskbot