-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Improve migration unit tests #6881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
No QA Needed
Apply this label when your PR does not need any QA effort.
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Jul 24, 2023
Gudahtt
force-pushed
the
improve-migration-unit-tests
branch
4 times, most recently
from
July 25, 2023 16:32
e1f1f76
to
9540678
Compare
3 tasks
Gudahtt
force-pushed
the
improve-migration-unit-tests
branch
3 times, most recently
from
July 25, 2023 20:41
ba3370c
to
4233be3
Compare
The migration unit tests have been updated to group tests by the migration number. One additional test case has been added as well, to cover the case where the affected state doesn't exist. This change was done to simplify PR #6872, which is part of MetaMask/mobile-planning#798
Gudahtt
force-pushed
the
improve-migration-unit-tests
branch
from
July 26, 2023 11:42
4233be3
to
7046801
Compare
Kudos, SonarCloud Quality Gate passed! |
leotm
reviewed
Jul 26, 2023
leotm
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
leotm
reviewed
Jul 26, 2023
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Jul 26, 2023
metamaskbot
added
the
release-7.5.0
Issue or pull request that will be included in release 7.5.0
label
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.5.0
Issue or pull request that will be included in release 7.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
The migration unit tests have been updated to group tests by the migration number. One additional test case has been added as well, to cover the case where the affected state doesn't exist.
Issue
This change was done to simplify PR #6872, which is part of https://github.com/MetaMask/mobile-planning/issues/798
Checklist