test: Check if fixtures server is running before teardown #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
changed the title
Codecov Report
@@ Coverage Diff @@
## main #7006 +/- ##
=======================================
Coverage 32.64% 32.64%
=======================================
Files 994 994
Lines 26641 26641
Branches 2088 2088
=======================================
Hits 8697 8697
Misses 17530 17530
Partials 414 414 |
vinistevam
added
the
team-confirmations-system
vinistevam
changed the title
vinistevam
changed the title
OGPoyraz
previously approved these changes
Aug 18, 2023
Andepande
previously approved these changes
Aug 18, 2023
matthewwalsh0
previously approved these changes
Aug 18, 2023
vinistevam
dismissed stale reviews from matthewwalsh0, Andepande, and OGPoyraz
via
89e134f
Andepande
approved these changes
Aug 18, 2023
OGPoyraz
approved these changes
Aug 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
metamaskbot
added
the
release-7.6.0
vinistevam
added
the
No QA Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
This PR aims to improve the tearndown process for fixtures using
withFixtureshelper function. It was reported that in some cases the retry mechanism was not working and adding a check to ensure that the server is running before stopping it resolved the issue.startFixturesServerto only start when required by the test case.Screenshots/Recordings
http://recordit.co/75fnRudGuN
E2E
Detox:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/494c3e27-a418-43eb-916c-21a2cef29998
Wdio:
https://app.bitrise.io/build/611ae3ae-fb84-480f-9952-acade3391b02
Issue
fixes https://github.com/MetaMask/mobile-planning/issues/1196
Checklist