-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Check if fixtures server is running before teardown #7006
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## main #7006 +/- ##
=======================================
Coverage 32.64% 32.64%
=======================================
Files 994 994
Lines 26641 26641
Branches 2088 2088
=======================================
Hits 8697 8697
Misses 17530 17530
Partials 414 414 |
89e134f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮 🌮
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
: PR requires manual QA.No QA/E2E only
: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build
: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passed
label when QA has signed off (Only required if the PR was labeled withneeds-qa
)team-
(orexternal-contributor
label if your not a MetaMask employee)Description
This PR aims to improve the tearndown process for fixtures using
withFixtures
helper function. It was reported that in some cases the retry mechanism was not working and adding a check to ensure that the server is running before stopping it resolved the issue.startFixturesServer
to only start when required by the test case.Screenshots/Recordings
http://recordit.co/75fnRudGuN
E2E
Detox:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/494c3e27-a418-43eb-916c-21a2cef29998
Wdio:
https://app.bitrise.io/build/611ae3ae-fb84-480f-9952-acade3391b02
Issue
fixes https://github.com/MetaMask/mobile-planning/issues/1196
Checklist