fix: support importing account while connecting #7010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
added
the
team-confirmations-system
vinistevam
approved these changes
Aug 17, 2023
|
Closed so we can fix on the release branch first. |
matthewwalsh0
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve issue causing the modal to prematurely close after importing an account while connecting to a dApp.
The issue was that the navigation in the
PermissionApprovalcomponent was running on every render, meaning duplicate navigations were being performed that ultimately meant closing the import success screen closed the entire navigation stack rather than returning to the original connect modal.See issue for steps to reproduce.
Issue
Fixes #1192
Checklist