-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: android sdk reconnection #7015
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## main #7015 +/- ##
==========================================
- Coverage 32.64% 32.64% -0.01%
==========================================
Files 994 994
Lines 26638 26641 +3
Branches 2088 2088
==========================================
Hits 8697 8697
- Misses 17527 17530 +3
Partials 414 414
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
: PR requires manual QA.No QA/E2E only
: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build
: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passed
label when QA has signed off (Only required if the PR was labeled withneeds-qa
)team-
(orexternal-contributor
label if your not a MetaMask employee)Description
This PR fixes two issues:
• When a user cancels a connection request, the wallet was not redirecting back to the dapp
• After cancelling a connection request and making another connection request, the wallet was not showing the connection prompt. The reason for this is that the client info was persisted before the connection request was approved, and subsequent connection requests were perceived as reconnection - yet a bridge wasn't set up for that client id yet.
Screenshots/Recordings
dapp-reconnection.mp4
Issue
fixes #???
Checklist