-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Post comment after e2e smoke #8495
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8495 +/- ##
=======================================
Coverage 41.60% 41.60%
=======================================
Files 1267 1267
Lines 30722 30722
Branches 3062 3062
=======================================
Hits 12781 12781
Misses 17171 17171
Partials 770 770 ☔ View full report in Codecov by Sentry. |
Updated description to describe behavior - #8495 (comment) |
…k/metamask-mobile into ci/bitrise-message-check
Bitrise✅✅✅ Commit hash: 6036a02 Note
|
This comment was marked as spam.
This comment was marked as spam.
Bitrise✅✅✅ Commit hash: 1c3435f Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is massive! Good stuff Cal!!! 🌮 🌮 🌮 🌮
Description
The purpose of these changes is to add a Github check for checking E2E smoke test run status (for PRs that have
Run Smoke E2E
label applied). Under the hood, the action does the following:Run Smoke E2E
label is appliedRelated issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1552
Manual testing steps
Scenario
Check Bitrise E2E status
will fail if Bitrise status comment with last non-merge commit hash either doesn't exist, is pending, or failedRun Smoke E2E
label is appliedScenario
Check Bitrise E2E status
will pass if Bitrise E2E smoke comment with last non-merge commit hash is posted as a successful buildRun Smoke E2E
label is appliedScenario
Check Bitrise E2E status
will pass if E2E smoke label is appliedRun E2E Smoke
label is not applied to the PRScreenshots/Recordings
Before
After
Check fails when comment shows pending
https://github.com/MetaMask/metamask-mobile/assets/10508597/01be00e3-a0e8-4c14-96eb-e884d9829507
Check fails since no Bitrise comment exists with latest commit
https://github.com/MetaMask/metamask-mobile/assets/10508597/ab0ac40d-322f-4f1f-9bff-ee2cc3ef436e
Check passes with Bitrise comment showing pass on latest commit
https://github.com/MetaMask/metamask-mobile/assets/10508597/9ffbd0c5-4b3b-426d-9396-cfb271da8422
Check passes with Bitrise comment showing pass on latest non-main merge commit
https://github.com/MetaMask/metamask-mobile/assets/10508597/415fb89c-a873-4a4f-86c5-afc06c0d6a90
Comment shows failed when Bitrise build fails. Check will also detect this and fail.
https://github.com/MetaMask/metamask-mobile/assets/10508597/aee06b95-06b8-4861-8611-d2cdda219fd4
Check passes with Bitrise comment showing pass on a later merge from main commit
https://github.com/MetaMask/metamask-mobile/assets/10508597/dacc0c99-e2a4-434c-be7a-00e63cb34c14
Pre-merge author checklist
Pre-merge reviewer checklist