chore: cherry-pick #8469 #8499
Merged
chore: cherry-pick #8469 #8499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
## **Description** This PR addresses a deeplink navigation issue found in MetaMask Mobile v7.10.0 and above ([LINK TO THE BUG](#7766)). The update introduces key improvements for handling deeplinks: **Issue Overview:** Previously, deeplinks failed to function correctly when the MetaMask app was not running in the background. This was caused by premature route navigation attempts before the app completed its loading process. **Implemented Solutions:** **Conditional Deeplink Queueing**: A queue system for deeplinks has been implemented. Deeplinks that are triggered by [branch.io](http://branch.io/) events are queued if the app is not fully initialized. This queued processing ensures that deeplinks are handled correctly only once the app loads completely. **Immediate Handling When the App Loaded:** For instances where the app is already loaded, deeplinks from [branch.io](http://branch.io/) events are processed immediately and normally, without queuing. This ensures direct and standard handling of deeplinks in an active app state. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/MetaMask/metamask-mobile/assets/61094771/629803d3-0dea-4dd8-95b0-c509d248b07a <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be11f281-6b5a-4f79-8251-a264441016b5 |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NicolasMassart
approved these changes
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/7.16.0 #8499 +/- ##
==================================================
- Coverage 40.67% 40.62% -0.05%
==================================================
Files 1240 1239 -1
Lines 30012 30001 -11
Branches 2871 2871
==================================================
- Hits 12206 12188 -18
- Misses 17107 17113 +6
- Partials 699 700 +1 ☔ View full report in Codecov by Sentry. |
|
metamaskbot
added
the
release-7.16.0
|
No release label on PR. Adding release label release-7.16.0 on PR, as PR was cherry-picked in branch 7.16.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #8469