Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick #8469 #8499

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Commits on Feb 1, 2024

  1. fix: deeplink handling issue when the app is closed (#8469)

    ## **Description**
    
    This PR addresses a deeplink navigation issue found in MetaMask Mobile
    v7.10.0 and above ([LINK TO THE
    BUG](#7766)). The
    update introduces key improvements for handling deeplinks:
    
    **Issue Overview:**
    Previously, deeplinks failed to function correctly when the MetaMask app
    was not running in the background. This was caused by premature route
    navigation attempts before the app completed its loading process.
    
    **Implemented Solutions:**
    
    **Conditional Deeplink Queueing**:
    A queue system for deeplinks has been implemented. Deeplinks that are
    triggered by [branch.io](http://branch.io/) events are queued if the app
    is not fully initialized. This queued processing ensures that deeplinks
    are handled correctly only once the app loads completely.
    
    **Immediate Handling When the App Loaded:**
    For instances where the app is already loaded, deeplinks from
    [branch.io](http://branch.io/) events are processed immediately and
    normally, without queuing. This ensures direct and standard handling of
    deeplinks in an active app state.
    
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    
    https://github.com/MetaMask/metamask-mobile/assets/61094771/629803d3-0dea-4dd8-95b0-c509d248b07a
    
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [x] I’ve followed [MetaMask Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've clearly explained what problem this PR is solving and how it
    is solved.
    - [x] I've linked related issues
    - [x] I've included manual testing steps
    - [x] I've included screenshots/recordings if applicable
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    - [x] I’ve properly set the pull request status:
      - [x] In case it's not yet "ready for review", I've set it to "draft".
    - [x] In case it's "ready for review", I've changed it from "draft" to
    "non-draft".
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    omridan159 authored and metamaskbot committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    874122a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42c357e View commit details
    Browse the repository at this point in the history