Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1408 Native Alert Patch for Webview #8515

Merged
merged 10 commits into from
Feb 26, 2024
Merged

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Feb 2, 2024

Description

Currently on iOS when the user is promted with an alert to grant permissions for a website that has a big domain, it will hide the entire Alert message that the website is requesting.

Related issues

https://github.com/MetaMask/mobile-planning/issues/1408

Fixes:

Manual testing steps

  1. Go to this page...

e2e Testing

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abb68302-f423-4084-9cd5-3fef3a0a5c7c

Screenshots/Recordings

Before:

This is the website we can use for debugging purposes: https://nfttoks.crypto.comsssssssss.go.f-secure.com.egghunter.in/camera.html

After:
Screenshot 2024-02-02 at 16 10 13

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau added Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-mobile-client team-mobile-platform labels Feb 2, 2024
@MarioAslau MarioAslau self-assigned this Feb 2, 2024
@MarioAslau MarioAslau requested a review from a team as a code owner February 2, 2024 16:38
Copy link
Contributor

github-actions bot commented Feb 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau changed the title bug: #1408 Native Alert Patch for Webview fix: #1408 Native Alert Patch for Webview Feb 2, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

ios/MetaMask.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
ios/MetaMask.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
patches/react-native-webview+11.13.0.patch Show resolved Hide resolved
patches/react-native-webview+11.13.0.patch Show resolved Hide resolved
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.47%. Comparing base (667d8c8) to head (99d9aeb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8515   +/-   ##
=======================================
  Coverage   41.47%   41.47%           
=======================================
  Files        1263     1263           
  Lines       30605    30605           
  Branches     3008     3008           
=======================================
  Hits        12694    12694           
  Misses      17157    17157           
  Partials      754      754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@NicholasEllul NicholasEllul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes satisfy requirements from our team. Great work!

@MarioAslau MarioAslau merged commit 60fc586 into main Feb 26, 2024
36 checks passed
@MarioAslau MarioAslau deleted the bug/1408-native-dialogue branch February 26, 2024 22:41
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants