-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve localization workflow such that it allows for branch/PR focused translation #8565
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8565 +/- ##
==========================================
+ Coverage 40.90% 45.50% +4.60%
==========================================
Files 1245 1275 +30
Lines 30150 31202 +1052
Branches 2895 3184 +289
==========================================
+ Hits 12333 14199 +1866
+ Misses 17114 16163 -951
- Partials 703 840 +137 ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby sign the CLA |
Quality Gate passedIssues Measures |
7897cdb
to
7c86692
Compare
- This allows for branch/PR focused translations
7c86692
to
dc227bd
Compare
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This allows for branch/PR focused translations
Description
Currently, translation only happens once changes to the en.json file are merged to main. These changes could include new keys being added or changes to english text. What this means is that there is no way currently to require that translations be in place before the feature goes live. It could make it through translation before being released but there is currently no way to require that we wait for translations.
Related issues
Fixes: 8564
Manual testing steps - To be done after merge and with Desi
Use case 1 (feature branch requires translation):
Use Case 2 (main branch translations):
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist