-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fake native tokens need better UX error handling #8572
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ea75708-64bf-49ba-b246-cd5de618b4b6 |
9a1a13f
to
b968408
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8572 +/- ##
==========================================
- Coverage 41.42% 41.39% -0.03%
==========================================
Files 1270 1272 +2
Lines 30832 30950 +118
Branches 3046 3062 +16
==========================================
+ Hits 12772 12812 +40
- Misses 17296 17369 +73
- Partials 764 769 +5 ☔ View full report in Codecov by Sentry. |
fc62310
to
28b7b17
Compare
28b7b17
to
72fa3b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Looks like there are failing unit tests as well
bf5a2ec
to
40e84ae
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7ce984a8-9156-4ef2-847b-8375d17bf34d |
aeb61a5
to
80f6c2e
Compare
0adca6e
to
809e207
Compare
Bitrise🔄🔄🔄 Commit hash: f9df61f Note
|
6803f8d
to
8228c4e
Compare
8228c4e
to
e7dc98d
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a testing perspective
Hey @salimtb I just realized there were additions to the Ramp folder, to be exact the files:
These must have been added before our cc: @Cal-L @cortisiko |
Description
In response to recent scam incidents we're adding mitigations to help prevent users from adding malicious networks and being shown inaccurate token values.
Implementation of this ticket will:
Show N/A for a native token value, when the native token symbol does not match the chain ID as publicly known
Show a tooltip that when tapped shows a bottom sheet explainer
The explainer directs the user to update their Network details for the network the token balance is requested for
User story
As a user I want to be informed that a token balance might be inaccurate, so that I don't make decisions to transfer or buy assets based on this information
As a user I want to be informed when a custom network might be trying to scam me
Related issues
Fixes: #1354
Manual testing steps
2.change the symbol from MATIC to ETH
Screenshots/Recordings
Before
before.mov
After
https://drive.google.com/drive/folders/1lcKOyC7U1r9OW2qt7BjsReGdG-02EysJ?usp=sharing
Pre-merge author checklist
Pre-merge reviewer checklist