-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support updated Linea gas fee estimation #8581
Conversation
Override gas fee estimates if transaction has suggested gas fees. Update transaction controller patch to use gas fee flows.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8581 +/- ##
==========================================
+ Coverage 41.47% 41.55% +0.07%
==========================================
Files 1263 1267 +4
Lines 30605 30648 +43
Branches 3008 3011 +3
==========================================
+ Hits 12694 12735 +41
- Misses 17157 17158 +1
- Partials 754 755 +1 ☔ View full report in Codecov by Sentry. |
QA build, Samsung s24+ physical device. MM production gas fees on Linea Goerli: Gas fee on Linea Goerli on current branch doesn't change whenever 'market', 'aggressive' or 'low' gas fee selected: |
Fix linting.
Gas fee doesn't change https://lineascan.build/address/0x2990079bcdEe240329a520d2444386FC119da21a |
QA build, Samsung s24+ physical device. Linea mainnet current branch: nonce 114 and 115 market gas fees of 1.0816 GWEI and 1.0819 GWEI Linea mainnet production: nonce 120 and 121 market gas fees of 1.0796 GWEI and 1.0793 GWEI Linea Goerli current branch: nonce 68 and 69 market gas fee 0.5820 GWEI Linea Goerli production: nonce 62 and 63 market gas fee 0.5820 GWEI Similar issue on Sepolia and mainnet here: #8708 |
Check transaction gas fee estimates in send flow. Fix saving of custom gas fees in send flow. Reject transaction when leaving send confirmation.
Gas fees estimation adjusted accordingly to custom gas settings in the UI, transactions sent with the saved gas fees, custom gas settings reflected on block explorer. Mainnet https://etherscan.io/address/0x2990079bcdEe240329a520d2444386FC119da21a, 'send' transactions from the wallet Linea mainnet https://lineascan.build/address/0x2990079bcdEe240329a520d2444386FC119da21a, 'send' transactions from the wallet Sepolia https://sepolia.etherscan.io/address/0x2990079bcdEe240329a520d2444386FC119da21a, test dapp 'create token' transactions |
Quality Gate passedIssues Measures |
Description
When creating transactions on a Linea network, use the updated gas fee estimates provided by the
linea_estimateGas
RPC method.This is provided via the patched
TransactionController
which periodically updates these values in the newgasFeeEstimates
property of the transaction metadata.Specifically:
GasFeeController
,TransactionController
, and for general transaction confirmation.BaseControllerV1
controllers.Related issues
Fixes: #1531 #8708
Manual testing steps
Verify transactions are successfully submitted with the provided gas fees with permutations of:
If possible, verify that the gas fees for an identical transaction are lower than the previous commit.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist