fix: filter SES from Sentry stack trace frames #8584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SES is shown at the top of the stack trace, but we don't have a lockdown (repairIntrinsics) option to hide it yet
this simply removes the SES frame from the Sentry error event stack trace
we identify this with ease by the
filename
, rather than the verbosecontext_line
here's an example of a SES Sentry error event stack trace frame that we remove:
https://docs.sentry.io/platforms/javascript/configuration/filtering
https://github.com/endojs/endo/blob/master/packages/ses/docs/reference.md#options-quick-reference
Related issues
Fixes: #8586
Manual testing steps
npx @sentry/wizard
sentry.properties
app/util/sentry/utils.js
Sentry.init({dsn: xxx})
yarn setup
<Button title='Try!' onPress={ () => { Sentry.captureException(new Error('First error')) }}/>
Sentry.captureException('test')
Sentry.nativeCrash()
throw new Error('test')
Error(ses)
no longer seenapp:///ses.cjs
frame no longer present in stack traceapp:///ses.cjs
still present in breadcrumbsScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist